otterc commented on a change in pull request #31934:
URL: https://github.com/apache/spark/pull/31934#discussion_r599761803
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -639,7 +624,7 @@ public void onData(String streamId, ByteBuffer buf) throws
IOException {
// written to disk due to this reason. We thus decide to optimize
for server
// throughput and memory usage.
if (deferredBufs == null) {
- deferredBufs = new LinkedList<>();
+ deferredBufs = new ArrayList<>();
Review comment:
Quoting @mridulm
"make this ArrayList instead - LinkedList has bad perf charactestics in
comparison, and is preferable only when we have removes."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
