sarutak commented on a change in pull request #31854:
URL: https://github.com/apache/spark/pull/31854#discussion_r600162755
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2738,6 +2738,31 @@ class DataFrameSuite extends QueryTest
checkAnswer(df.select(col2), Row(1) :: Row(2) :: Row(3) :: Nil)
}
+ test("SPARK-34763: col(), $\"<name>\", df(\"name\") should handle quoted
column name properly") {
+ val df1 = spark.sql("SELECT 'col1' AS `a``b.c`")
+ checkAnswer(df1.selectExpr("`a``b.c`"), Row("col1"))
+ checkAnswer(df1.select(df1("`a``b.c`")), Row("col1"))
+ checkAnswer(df1.select(col("`a``b.c`")), Row("col1"))
+ checkAnswer(df1.select($"`a``b.c`"), Row("col1"))
+
+ val df2 = df1.as("d.e`f")
+ checkAnswer(df2.selectExpr("`a``b.c`"), Row("col1"))
+ checkAnswer(df2.select(df2("`a``b.c`")), Row("col1"))
+ checkAnswer(df2.select(col("`a``b.c`")), Row("col1"))
+ checkAnswer(df2.select($"`a``b.c`"), Row("col1"))
+
+ checkAnswer(df2.selectExpr("`d.e``f`.`a``b.c`"), Row("col1"))
+ checkAnswer(df2.select(df2("`d.e``f`.`a``b.c`")), Row("col1"))
+ checkAnswer(df2.select(col("`d.e``f`.`a``b.c`")), Row("col1"))
+ checkAnswer(df2.select($"`d.e``f`.`a``b.c`"), Row("col1"))
+
+ val df3 = df1.as("*-#&% ?")
+ checkAnswer(df3.selectExpr("`*-#&% ?`.`a``b.c`"), Row("col1"))
+ checkAnswer(df3.select(df3("*-#&% ?.`a``b.c`")), Row("col1"))
+ checkAnswer(df3.select(col("*-#&% ?.`a``b.c`")), Row("col1"))
+ checkAnswer(df3.select($"*-#&% ?.`a``b.c`"), Row("col1"))
Review comment:
> ow many tests are broken if we switch to parseMultipartIdentifier
40+ tests fail.
https://github.com/apache/spark/runs/2164624369?check_suite_focus=true
> I don't think this is intentional
Hmm, according to the comment on `UnresolvedAttribute.quotedString`, it
seems to rely on the behavior.
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala#L188-L193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
