cloud-fan commented on a change in pull request #31940:
URL: https://github.com/apache/spark/pull/31940#discussion_r600220399
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -4007,6 +4009,16 @@ object ApplyCharTypePadding extends Rule[LogicalPlan] {
b.withNewChildren(newChildren.reverse)
}.getOrElse(b)
+ case b @ BinaryComparison(OuterReference(attr: Attribute), lit) if
lit.foldable =>
+ padOuterAttrLitComp(attr, lit).map { newChildren =>
Review comment:
shall we let `padAttrLitCmp` to take `Expression` and `Metadata`,
instead of `Attribute`, so that we can pass `OuterReference` to `padAttrLitCmp`
directly and we don't need to create `padOuterAttrLitComp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
