Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42126473
Yes, but those are transitive dependencies. `core` happens to bring in both
lang and lang3, and this was using the old lang dependency even. It would be
correct-er to either depend directly on it, or not use it. To me it seems
better to inline what amounts to one-liner access of a standard system
property.
I think it's also true that Guava is the go-to utility package and would be
better to use Guava where possible rather than encourage use of lang too.
The use of lang3 in ReplSuite should also either be 'inlined', or else
supplemented with a direct test-scope dependency. It's just a test, so not as
big of an issue. I think the one use can even be replaced with a simple escape,
which I presume is there to handle backslash on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
