xkrogen commented on a change in pull request #31936: URL: https://github.com/apache/spark/pull/31936#discussion_r600686258
########## File path: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnShuffleAlternateNameConfigSuite.scala ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.deploy.yarn + +import java.net.URLClassLoader + +import org.apache.hadoop.yarn.conf.YarnConfiguration + +import org.apache.spark._ +import org.apache.spark.internal.config._ +import org.apache.spark.network.yarn.{YarnShuffleService, YarnTestAccessor} +import org.apache.spark.tags.ExtendedYarnTest + +/** + * SPARK-34828: Integration test for the external shuffle service with an alternate name and + * configs (by using a configuration overlay) + */ +@ExtendedYarnTest +class YarnShuffleAlternateNameConfigSuite extends YarnShuffleIntegrationSuite { + + private[this] val shuffleServiceName = "custom_shuffle_service_name" + + override def newYarnConfig(): YarnConfiguration = { + val yarnConfig = super.newYarnConfig() + yarnConfig.set(YarnConfiguration.NM_AUX_SERVICES, shuffleServiceName) + yarnConfig.set(YarnConfiguration.NM_AUX_SERVICE_FMT.format(shuffleServiceName), + classOf[YarnShuffleService].getCanonicalName) + val overlayConf = new YarnConfiguration() + // Enable authentication in the base NodeManager conf but not in the client. This would break + // shuffle, unless the shuffle service conf overlay overrides to turn off authentication. + overlayConf.setBoolean(NETWORK_AUTH_ENABLED.key, true) + // Add the authentication conf to a separate config object used as an overlay rather than + // setting it directly. This is necessary because a config overlay will override previous + // config overlays, but not configs which were set directly on the config object. + yarnConfig.addResource(overlayConf) + yarnConfig + } + + override protected def extraSparkConf(): Map[String, String] = + super.extraSparkConf() ++ Map(SHUFFLE_SERVICE_NAME.key -> shuffleServiceName) Review comment: Hadoop 2.7 uses it the same way newer versions of Hadoop do, as discussed above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
