cloud-fan commented on a change in pull request #31791:
URL: https://github.com/apache/spark/pull/31791#discussion_r600754093
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -556,11 +557,56 @@ object Range {
val output = StructType(StructField("id", LongType, nullable = false) ::
Nil).toAttributes
new Range(start, end, step, numSlices, output, isStreaming)
}
+
def apply(start: Long, end: Long, step: Long, numSlices: Int): Range = {
Range(start, end, step, Some(numSlices))
}
+
+ private def castAndEval[T](expression: Expression, dataType: DataType): T = {
+ TypeCoercion.implicitCast(expression, dataType)
Review comment:
What's the behavior before this PR? We probably don't have to follow the
type coercion rules and only allow `IntegralType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
