maropu commented on a change in pull request #31955:
URL: https://github.com/apache/spark/pull/31955#discussion_r600961181
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##########
@@ -124,10 +124,10 @@ case class ScalaUDF(
val toRow = enc.createSerializer().asInstanceOf[Any => Any]
if (enc.isSerializedAsStructForTopLevel) {
value: Any =>
- if (value == null) null else toRow(value).asInstanceOf[InternalRow]
+ if (value == null) null else
toRow(value).asInstanceOf[InternalRow].copy()
} else {
value: Any =>
- if (value == null) null else
toRow(value).asInstanceOf[InternalRow].get(0, dataType)
+ if (value == null) null else
toRow(value).asInstanceOf[InternalRow].copy().get(0, dataType)
Review comment:
Why do we need `copy` now after #28979? IIUC blocking plans (e.g.,
aggregates and sorts) copy results in their plan side if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
