Ngone51 commented on a change in pull request #31934:
URL: https://github.com/apache/spark/pull/31934#discussion_r600994466
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -738,14 +723,14 @@ public void onFailure(String streamId, Throwable
throwable) throws IOException {
Map<Integer, AppShufflePartitionInfo> shufflePartitions =
mergeManager.partitions.get(partitionInfo.appShuffleId);
if (shufflePartitions != null &&
shufflePartitions.containsKey(partitionInfo.reduceId)) {
- logger.debug("{} shuffleId {} reduceId {} set encountered failure",
+ logger.debug("{} shuffleId {} reduceId {} encountered failure",
partitionInfo.appShuffleId.appId,
partitionInfo.appShuffleId.shuffleId,
partitionInfo.reduceId);
partitionInfo.setCurrentMapIndex(-1);
- partitionInfo.setEncounteredFailure(true);
}
}
}
+ isWriting = false;
Review comment:
Ok, keeping it consistent sounds fine. we can leave it as it is since
it's trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
