LuciferYang commented on a change in pull request #31517:
URL: https://github.com/apache/spark/pull/31517#discussion_r601008117
##########
File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
##########
@@ -431,9 +433,10 @@ class ExecutorSuite extends SparkFunSuite
}
}
- def errorInGuavaCache(e: => Throwable): Throwable = {
- val cache = CacheBuilder.newBuilder()
- .build(new CacheLoader[String, String] {
+ def errorInCaffeinatedGuavaCache(e: => Throwable): Throwable = {
+ val builder = Caffeine.newBuilder()
Review comment:
I found that we need to use `CaffeinatedGuava` with `com.google.common
. cache.CacheLoader` to build cache pass this test, this combination is
compatible with the exception handling behavior of `Guava` cache
Use `CaffeinatedGuava` with `com.github.benmanes.caffeine.cache.CacheLoader`
or use `Caffeine` directly will make this test fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
