HeartSaVioR edited a comment on pull request #31937: URL: https://github.com/apache/spark/pull/31937#issuecomment-806397850
@xuanyuanking @viirya Sounds great! Thanks for lending your hands. My current plan on breakdown of PR follows: * (no dependency) UpdatingSessionIterator + UpdatingSessionIteratorSuite * (no dependency) MergingSessionIterator - there's no test for AggregateIterator implementations so far, but would be good if we can have one for this. volunteer welcome!. * (no dependency) StreamingSessionWindowStateManager and relevant changes (StateStoreType, SymmetricHashJoinStateManager) - no test suite for StreamingSessionWindowStateManager now, volunteer welcome! * (depends on StreamingSessionWindowStateManager) MergingSortWithSessionWindowStateIterator - no test suite for now. volunteer welcome!. * (depends on all above) all other parts including physical exec node for above iterators Appreciate the voices on the plan; I'm also OK to attach physical exec node along with iterator (e.g. UpdatingSessionIterator + UpdatingSessionExec) to verify precondition of iterator is respected from exec node. I also have willingness to add test suite for missing spots. Once we make sure we are good to go with this direction, I'll create three PRs which don't have dependency first, and ask for reviewing/helping add test suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
