cloud-fan commented on pull request #31913: URL: https://github.com/apache/spark/pull/31913#issuecomment-806721780
I assume `GroupingExprRef` should be similar to `Attribute` and needs to be bound to `BoundReference` before execution. You made a good point that properties like `nullable` may go out of sync. Actually the same applies to `Attribute` as well. The solution we made for `Attribute` is the rule `UpdateAttributeNullability`. We can update nullability of `GroupingExprRef` in that rule as well. In general, `GroupingExprRef` should be a variant of `Attribute`. It's bound to the grouping expression in the current operator, instead of the output of child operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
