cloud-fan commented on a change in pull request #31954:
URL: https://github.com/apache/spark/pull/31954#discussion_r601485468



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1873,6 +1873,8 @@ object AnsiCast {
 
     case (NullType, _) => true
 
+    case (_, StringType) => true

Review comment:
       `df.show` needs to cast the column to string, I think we need to support 
casting from all the data types here, otherwise `df.show` may still be broken 
under some cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to