cloud-fan commented on a change in pull request #31355:
URL: https://github.com/apache/spark/pull/31355#discussion_r601573880



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/connector/WriteDistributionAndOrderingSuite.scala
##########
@@ -569,4 +785,26 @@ class WriteDistributionAndOrderingSuite
         fail("expected V2TableWriteExec")
     }
   }
+
+  private def orderedWritePartitioning(
+      writeOrdering: Seq[catalyst.expressions.SortOrder],
+      targetNumPartitions: Option[Int]): physical.Partitioning = {
+    targetNumPartitions match {
+      case Some(parts) => RangePartitioning(writeOrdering, parts)
+      case _ => RangePartitioning(writeOrdering, conf.numShufflePartitions)
+    }
+  }
+
+  private def clusteredTableDistribution(clustering: Array[Expression]): 
Distribution = {
+    Distributions.clustered(clustering)

Review comment:
       `clusteredTableDistribution` doesn't seem to be shorter than 
`Distributions.clustered` ...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to