Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/4435#issuecomment-97245702
  
    Lemme summarize what I've addressed:
    
    * I changed the way jersey uses jackson to clean up the dependencies.  It 
leads to a setup that doesn't fit the standard json-with-jersey tutorials b/c 
of the version of jersey we want to use, but I've put in some comments on why 
we do it this way.
    * Style fixes -- indentation of multi-line parameter lists was wrong just 
about everywhere.  I've tried to be thorough with updating that.  (attempted 
and failed to get IntelliJ change its formatting ... would love to hear the 
secret if anybody knows.)
    * `StorageListener` and `StorageStatusListener` are now thread-safe (they 
weren't being used safely in the UI code before this) 
https://github.com/squito/spark/commit/52bbae82694339da1b0400604af0685157af8663
    * Added some explanatory docs in a few key parts (of course that is rather 
subjective)
    * I diffed the dependencies from `mvn dependency:tree` with master, and 
here is what is added:
    ```
    +- com.sun.jersey:jersey-server:jar:1.9:compile
        \- asm:asm:jar:3.1:compile
    +- com.sun.jersey:jersey-core:jar:1.9:compile
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to