cloud-fan commented on a change in pull request #31905:
URL: https://github.com/apache/spark/pull/31905#discussion_r602072774



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -683,6 +683,12 @@ class SparkSession private(
     ret
   }
 
+  def observation(expr: Column, exprs: Column*): Observation =

Review comment:
       It's a bit awkward to build an `Observation` with columns. The 
`Observation` looks like can be used with different DataFrames, but it is not 
because the columns are from a certain DataFrame.
   
   How about this:
   ```
   val observation = Observation("the name")
   df1.observe(observation, expressions...)...
   val res1 = observation.get
   
   df2.observe(observation, expressions...)...
   val res2 = observation.get
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to