hanover-fiste commented on a change in pull request #31965:
URL: https://github.com/apache/spark/pull/31965#discussion_r602115149
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -433,6 +433,61 @@ class JDBCSuite extends QueryTest
assert(ids(2) === 3)
}
+ test("SPARK-34843: columnPartition should generate a correct stride size") {
Review comment:
It was to explicitly test out different parts of the code change. The
first test was for proper stride size, the second test was for realignment of
the lower bound. However, the second test does implicitly test out both. I've
removed the first test since it doesn't add much value and is one more thing to
maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
