Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/630#discussion_r12260752
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -253,7 +254,12 @@ object SparkSubmit {
     
         val mainClass = Class.forName(childMainClass, true, loader)
         val mainMethod = mainClass.getMethod("main", new 
Array[String](0).getClass)
    -    mainMethod.invoke(null, childArgs.toArray)
    +    try {
    +      mainMethod.invoke(null, childArgs.toArray)
    +    } catch {
    +      case e: InvocationTargetException =>
    +        println("Exception in Invoked Method" + e.getTargetException)
    --- End diff --
    
    I think this is going to change behavior in two ways though. This will not 
print any stack trace, and the exception will not propagated up to main() where 
it will terminate the program with a non-zero status. Both of those seems like 
good normal things. Instead, just `throw e.getTargetException`? (I suppose it 
would be even better to handle the case of a `null` target, but that is not 
supposed to happen in normal use.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to