peter-toth commented on a change in pull request #31955:
URL: https://github.com/apache/spark/pull/31955#discussion_r602186118



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
##########
@@ -124,10 +124,10 @@ case class ScalaUDF(
     val toRow = enc.createSerializer().asInstanceOf[Any => Any]
     if (enc.isSerializedAsStructForTopLevel) {
       value: Any =>
-        if (value == null) null else toRow(value).asInstanceOf[InternalRow]
+        if (value == null) null else 
toRow(value).asInstanceOf[InternalRow].copy()
     } else {
       value: Any =>
-        if (value == null) null else 
toRow(value).asInstanceOf[InternalRow].get(0, dataType)
+        if (value == null) null else 
toRow(value).asInstanceOf[InternalRow].copy().get(0, dataType)

Review comment:
       I've reverted `ScalaUDF` change in 
https://github.com/apache/spark/pull/31955/commits/6feab1aa4bc059f57fde77d71fd2f95ea87b31c0
 and fixed affected higher order functions here: 
https://github.com/apache/spark/pull/31955/commits/3d22e3bf3cb570302115209132fc9f55c731fa63
 tests are in 
https://github.com/apache/spark/pull/31955/commits/d00e70596e1b679d2331375629249905e9c75395




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to