AngersZhuuuu commented on pull request #31971: URL: https://github.com/apache/spark/pull/31971#issuecomment-808607177
> @AngersZhuuuu Could you change PR's description. > > After this pr: > > ``` > Casting 128 to tinyint causes overflow > We should use DataType's catalogString. > ``` > > I guess `We should use DataType's catalogString.` is not a part of the error message. > > And I would move the before and after examples to the section `Does this PR introduce any user-facing change?`. The error message is the things that users face to. Done, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
