yaooqinn commented on a change in pull request #31968:
URL: https://github.com/apache/spark/pull/31968#discussion_r603209245
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala
##########
@@ -64,9 +64,15 @@ private[hive] class SparkSQLDriver(val context: SQLContext =
SparkSQLEnv.sqlCont
new VariableSubstitution().substitute(command)
}
context.sparkContext.setJobDescription(substitutorCommand)
- val execution =
context.sessionState.executePlan(context.sql(command).logicalPlan)
- hiveResponse = SQLExecution.withNewExecutionId(execution) {
+ val logicalPlan = context.sql(command).logicalPlan
Review comment:
Basically, this looks the same to me but just different from the
caller-sides. If we decide to handle them separately, I suggest we just move
the `SQLExecution.withNewExecutionId` into the `hiveResultString` and then skip
`Command` from wrapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
