maropu commented on a change in pull request #31680:
URL: https://github.com/apache/spark/pull/31680#discussion_r603794244



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
##########
@@ -34,7 +34,7 @@ class HiveContext private[hive](_sparkSession: SparkSession)
   self =>
 
   def this(sc: SparkContext) = {
-    
this(SparkSession.builder().sparkContext(HiveUtils.withHiveExternalCatalog(sc)).getOrCreate())

Review comment:
       `withHiveExternalCatalog` is used only for tests after this merged, so 
could you move it into a suitable place?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to