maropu commented on a change in pull request #31804:
URL: https://github.com/apache/spark/pull/31804#discussion_r603859991
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -510,11 +510,21 @@ case class ShowTables(
override def children: Seq[LogicalPlan] = Seq(namespace)
}
-object ShowTables {
+trait ShowTablesLegacyHelper {
+ def getOutputAttrs: Seq[Attribute]
Review comment:
(Sorry for my late reply...) How about simply inlining
`getLegacyOutputAttrs`? It seems there are the only two places where
`getLegacyOutputAttrs` is used, so I'm not sure that we need this trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
