cloud-fan commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r603902380
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
##########
@@ -86,6 +92,9 @@ private class PartitionIterator[T](reader:
PartitionReader[T]) extends Iterator[
if (!hasNext) {
throw QueryExecutionErrors.endOfStreamError()
}
+ reader.currentMetricsValues.foreach { metric =>
+ customMetrics(metric.name()) += metric.value()
Review comment:
shall we call `+=` or `=`? `reader` keeps alive and
`reader.currentMetricsValues` will keep increasing IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
