AngersZhuuuu commented on a change in pull request #31680:
URL: https://github.com/apache/spark/pull/31680#discussion_r604059281
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSharedStateSuite.scala
##########
@@ -88,4 +89,17 @@ class HiveSharedStateSuite extends SparkFunSuite {
assert(!ss.conf.get(WAREHOUSE_PATH).contains(invalidPath),
"session level conf should be passed to catalog")
}
+
+ test("SPARK-34568: We should respect enableHiveSupport when initialize
SparkSession") {
+ val conf = new SparkConf().setMaster("local").setAppName("SPARK-34568")
+ val sc = SparkContext.getOrCreate(conf)
+ val catalog = sc.conf.get(StaticSQLConf.CATALOG_IMPLEMENTATION)
+ sc.conf.set(StaticSQLConf.CATALOG_IMPLEMENTATION, "in-memory")
Review comment:
> try ... finally?
Done
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala
##########
@@ -685,3 +685,10 @@ private[hive] object HiveTestJars {
targetFile
}
}
+
+private[hive] object TestHiveUtils {
+ def withHiveExternalCatalog(sc: SparkContext): SparkContext = {
Review comment:
> Could you move this method into `TestHiveContext`?
Sure, more suitable place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
