AngersZhuuuu commented on a change in pull request #32001:
URL: https://github.com/apache/spark/pull/32001#discussion_r604077354
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1712,6 +1712,20 @@ class CastSuite extends CastSuiteBase {
assert(e3.contains("Casting 2147483648 to int causes overflow"))
}
}
+
+ test("SPARK-34902: Cast support DayTimeIntervalType and
YearMonthIntervalType") {
Review comment:
> @AngersZhuuuu Could you add tests for corner cases like `null`,
`Int/Long.MaxValue/MinValue`, `0`, please.
>
> What happens in casting a `Int` to `DayTimeIntervalType`? Will it be
automatically converted to `Long`?
Int.MinValue is not return 0. So should I add logic when less then 0 throw
exception or return 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
