tgravescs commented on pull request #31942: URL: https://github.com/apache/spark/pull/31942#issuecomment-810300498
Like was mentioned above I'm guessing this just happens so rarely that it hasn't been an issue. Looks like main case would be on rpc timeout but then it actually does respond during that timeout (ie got message in just as we called to removeRpcRequest) so I would guess that is a very small time window that could happen. I thought in most cases timeout would tear down the connection and then retry when appropriate so the time window of getting the response back seem pretty small. Maybe I'm missing a case though. Doesn't mean we shouldn't clean it up though, just would be nice to make sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
