karenfeng commented on a change in pull request #31666:
URL: https://github.com/apache/spark/pull/31666#discussion_r604265109



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1968,7 +1986,7 @@ class Analyzer(override val catalogManager: 
CatalogManager)
     resolveExpression(
       expr,
       resolveColumnByName = nameParts => {
-        plan.resolve(nameParts, resolver)
+        plan.resolve(nameParts, resolver, withMetadata = false)

Review comment:
       I was thinking about this too - I can make a symmetric parameter for 
`resolveExpressionByPlanChildren`. This change likely also has a wider breadth 
than needed; primarily, we don't want `ResolveMissingReferences` to touch 
metadata as that should be resolved in `AddMetadataCol`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to