viirya commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r604334593
##########
File path:
sql/core/src/test/scala/org/apache/spark/status/api/v1/sql/SqlResourceSuite.scala
##########
@@ -41,31 +42,32 @@ object SqlResourceSuite {
val nodeIdAndWSCGIdMap: Map[Long, Option[Long]] = Map(1L -> Some(1L))
+ val defaultAggregateMethod = SQLMetrics.defaultAggregateMethod("")
val filterNode = new SparkPlanGraphNode(1, FILTER, "",
- metrics = Seq(SQLPlanMetric(NUMBER_OF_OUTPUT_ROWS, 1, "")))
+ metrics = Seq(SQLPlanMetric(NUMBER_OF_OUTPUT_ROWS, 1, "",
defaultAggregateMethod)))
Review comment:
The default aggregate method is defined in `SQLMetrics`. For code
structure, it is far from the UI class `SQLPlanMetric` and also conceptionally
I don't think we should have a default aggregate method at `SQLPlanMetric`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
