cloud-fan commented on a change in pull request #31932:
URL: https://github.com/apache/spark/pull/31932#discussion_r604633980
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala
##########
@@ -27,9 +28,10 @@ import org.apache.spark.sql.types._
* When applied on empty data (i.e., count is zero), it returns NULL.
*/
abstract class Covariance(x: Expression, y: Expression, nullOnDivideByZero:
Boolean)
Review comment:
we can simply do `val left: Expression, val right: Expression` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
