Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5743#issuecomment-97285781
@aarondav Sounds reasonable. However, this might increase more complexity
to the codes. The current solution is very simple compared to the alternative
one.
In addition to modifying `TransportRequestHandler`, `StreamManager`,
`OneForOneStreamManager`, there are many existing unit tests involving
`StreamManager`. Once `StreamManager`'s current interface (especially
`getChunk`) is updated, these tests are needed to largely modified. I think it
is not worth doing that.
So I update the codes based on your suggestion, but keep `getChunk`
untouched. Please take a look. If you agree these additional complexity is not
needed, I can revert it to current solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
