sunchao commented on a change in pull request #31776:
URL: https://github.com/apache/spark/pull/31776#discussion_r605063241
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
##########
@@ -894,4 +904,15 @@ private void readPageV2(DataPageV2 page) throws
IOException {
throw new IOException("could not read page " + page + " in col " +
descriptor, e);
}
}
+
+ private boolean isTimestampTypeMatched(TimeUnit unit) {
Review comment:
I mean we can just change `private boolean` to `private static boolean`
since they are not depending on any of the state from the class, but it's a
really minor thing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
