wypoon commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r605139486
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/PartitionReader.java
##########
@@ -51,7 +51,8 @@
T get();
/**
- * Returns an array of custom task metrics. By default it returns empty
array.
+ * Returns an array of custom task metrics. By default it returns empty
array. Note that it is
+ * not recommended to put heavy logic in this method as it may affect
reading performance.
Review comment:
I think it is worth spelling out when
`PartitionReader#currentMetricsValues()` is called on the DS v2, and how the
values are used (in this case, they are used to set the long in the
`SQLMetric`, not added to it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
