maropu commented on a change in pull request #32022:
URL: https://github.com/apache/spark/pull/32022#discussion_r606129184
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -914,19 +914,19 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with
SQLConfHelper with Logg
selectExpressions: Seq[NamedExpression],
query: LogicalPlan): LogicalPlan = withOrigin(ctx) {
if (ctx.groupingExpressionsWithGroupingAnalytics.isEmpty) {
- val groupByExpressions = expressionList(ctx.groupingExpressions)
if (ctx.GROUPING != null) {
- // GROUP BY .... GROUPING SETS (...)
- // `GROUP BY warehouse, product GROUPING SETS((warehouse, producets),
(warehouse))` is
- // semantically equivalent to `GROUP BY GROUPING SETS((warehouse,
produce), (warehouse))`.
- // Under this grammar, the fields appearing in `GROUPING SETS`'s
groupingSets must be a
- // subset of the columns appearing in group by expression.
+ // GROUP BY GROUPING SETS (...)
+ if (!ctx.groupingExpressions.isEmpty) {
Review comment:
Is it possible to show the warning log only once? I'm a bit worried that
existing users operate a service that use the syntax in production and they
will receive many warning messages when upgrading Spark into 3.2.0+. Or,
`logWarning` -> `logInfo`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
