Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/627#discussion_r12263308
--- Diff: bin/spark-class ---
@@ -138,7 +138,14 @@ if [ -e "$TOOLS_DIR"/target/spark-tools*[0-9Tg].jar ];
then
fi
# Compute classpath using external script
-CLASSPATH=`$FWDIR/bin/compute-classpath.sh`
+CLASSPATH_OUTPUT=$($FWDIR/bin/compute-classpath.sh)
--- End diff --
I also like that style, but this class uses the other style (always uses
all-caps) pervasively. I can change it though, will just become inconsistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
