BOOTMGR commented on pull request #32024: URL: https://github.com/apache/spark/pull/32024#issuecomment-812840514
> I suppose getMetricsByName references it too. > I'm not sure if it is possible to do these concurrently but doesn't hurt. By `getMetricsByName` I assume you mean `getSourcesByName`. Thanks for pointing out that. Since we compact buffer in case of remove, it perfectly makes sense to synchronize get operation. I have updated patch to synchronize it. Bdw, do you think synchronizing all of them on same object would be performant enough? or we should opt for `ReadWriteLock`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
