itholic commented on a change in pull request #32036: URL: https://github.com/apache/spark/pull/32036#discussion_r606943218
########## File path: python/pyspark/pandas/__init__.py ########## @@ -0,0 +1,209 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import os +import sys +from distutils.version import LooseVersion + +from pyspark.pandas.version import __version__ # noqa: F401 + + +def assert_python_version(): + import warnings + + major = 3 + minor = 5 + deprecated_version = (major, minor) + min_supported_version = (major, minor + 1) + + if sys.version_info[:2] <= deprecated_version: + warnings.warn( + "Koalas support for Python {dep_ver} is deprecated and will be dropped in " + "the future release. At that point, existing Python {dep_ver} workflows " + "that use Koalas will continue to work without modification, but Python {dep_ver} " + "users will no longer get access to the latest Koalas features and bugfixes. " + "We recommend that you upgrade to Python {min_ver} or newer.".format( + dep_ver=".".join(map(str, deprecated_version)), + min_ver=".".join(map(str, min_supported_version)), + ), + FutureWarning, + ) + + +def assert_pyspark_version(): + import logging + + try: + import pyspark + except ImportError: + raise ImportError( + "Unable to import pyspark - consider doing a pip install with [spark] " + "extra to install pyspark with pip" + ) + else: + pyspark_ver = getattr(pyspark, "__version__") + if pyspark_ver is None or LooseVersion(pyspark_ver) < LooseVersion("2.4"): + logging.warning( + 'Found pyspark version "{}" installed. pyspark>=2.4.0 is recommended.'.format( + pyspark_ver if pyspark_ver is not None else "<unknown version>" + ) + ) Review comment: Correct! We'll address the all codes related with the existing third-party dependencies in the SPARK-34887. Thanks for the comment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
