tdas commented on a change in pull request #32058:
URL: https://github.com/apache/spark/pull/32058#discussion_r607878704
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -420,13 +420,15 @@ case class DeleteAction(condition: Option[Expression])
extends MergeAction
case class UpdateAction(
condition: Option[Expression],
- assignments: Seq[Assignment]) extends MergeAction {
+ assignments: Seq[Assignment],
+ assignStar: Boolean) extends MergeAction {
override def children: Seq[Expression] = condition.toSeq ++ assignments
}
case class InsertAction(
condition: Option[Expression],
- assignments: Seq[Assignment]) extends MergeAction {
+ assignments: Seq[Assignment],
+ assignStar: Boolean) extends MergeAction {
Review comment:
in that case shouldnt it be `InsertStarAction(condition)` and
`UpdateStarAction(condition)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]