tanelk commented on pull request #32057: URL: https://github.com/apache/spark/pull/32057#issuecomment-814335217
Perhaps @cloud-fan can comment on this. Why does `ObjectHashAggregateExec` require at least on of its aggregate functions to be `TypedImperativeAggregate`? https://github.com/apache/spark/blob/4b5fc1da752ec008468ef80a5717c8beab468387/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectHashAggregateExec.scala#L143-L149 Without that check the decision tree would be much simpler: 1) Are all agg buffers fixed with? Use `HashAggregateExec` 2) Is `conf.useObjectHashAggregation` enabled? Use `ObjectHashAggregateExec` 3) Use `SortAggregateExec` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
