allisonwang-db commented on a change in pull request #31791:
URL: https://github.com/apache/spark/pull/31791#discussion_r608221318
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -551,27 +552,84 @@ case class Sort(
/** Factory for constructing new `Range` nodes. */
object Range {
- def apply(start: Long, end: Long, step: Long,
- numSlices: Option[Int], isStreaming: Boolean = false): Range = {
- val output = StructType(StructField("id", LongType, nullable = false) ::
Nil).toAttributes
- new Range(start, end, step, numSlices, output, isStreaming)
- }
def apply(start: Long, end: Long, step: Long, numSlices: Int): Range = {
Range(start, end, step, Some(numSlices))
}
+
+ def getOutputAttrs: Seq[Attribute] = {
+ StructType(StructField("id", LongType, nullable = false) ::
Nil).toAttributes
+ }
+
+ private def typeCoercion: TypeCoercionBase = {
+ if (SQLConf.get.ansiEnabled) AnsiTypeCoercion else TypeCoercion
+ }
+
+ private def castAndEval[T](expression: Expression, dataType: DataType): T = {
+ typeCoercion.implicitCast(expression, dataType)
+ .map(_.eval())
+ .filter(_ != null)
+ .getOrElse {
+ throw
QueryCompilationErrors.incompatibleRangeInputDataTypeError(expression, dataType)
+ }.asInstanceOf[T]
+ }
+
+ def toLong(expression: Expression): Long = castAndEval[Long](expression,
LongType)
Review comment:
The original behaivor is to implicit cast the given value into expected
type:
https://github.com/apache/spark/blob/390d5bde81ce282a016c6cf36fb0d57012515388/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala#L40-L50
Where the expected types are hardcoded, for example `"end" -> LongType`
https://github.com/apache/spark/blob/390d5bde81ce282a016c6cf36fb0d57012515388/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala#L86-L88
It uses `TypeCoercion.implicitCast(value, expectedType)`. So here
`castAndEval` is trying to follow the previous behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
