ueshin commented on a change in pull request #32069:
URL: https://github.com/apache/spark/pull/32069#discussion_r608259435
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -161,6 +161,8 @@ jobs:
pyspark-sql, pyspark-mllib, pyspark-resource
- >-
pyspark-core, pyspark-streaming, pyspark-ml
+ - >-
+ pyspark-pandas
Review comment:
Maybe we can rebalance the pyspark tests after we finish porting unit
tests.
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -3506,7 +3506,7 @@ def style(self) -> "Styler":
Examples
--------
- >>> pp.range(1001).style # doctest: +ELLIPSIS
+ >>> pp.range(1001).style # doctest: +SKIP
Review comment:
`style` needs an optional dependency `Jinja2`.
##########
File path: python/pyspark/pandas/groupby.py
##########
@@ -1894,12 +1894,12 @@ def tail(self, n=5) -> Union[DataFrame, Series]:
... 'b': [2, 3, 1, 4, 6, 9, 8, 10, 7, 5],
... 'c': [3, 5, 2, 5, 1, 2, 6, 4, 3, 6]},
... columns=['a', 'b', 'c'],
- ... index=[7, 2, 4, 1, 3, 4, 9, 10, 5, 6])
+ ... index=[7, 2, 3, 1, 3, 4, 9, 10, 5, 6])
Review comment:
This is to reduce the test flakiness.
##########
File path: python/pyspark/pandas/sql_processor.py
##########
@@ -300,3 +300,33 @@ def _convert_var(self, var) -> Any:
if isinstance(var, (tuple, range)):
return self._convert_var(list(var))
raise ValueError("Unsupported variable type {}:
{}".format(type(var).__name__, str(var)))
+
+
+def _test():
+ import os
+ import doctest
+ import sys
+ from pyspark.sql import SparkSession
+ import pyspark.pandas.sql_processor
Review comment:
Renamed the file name from `sql.py` to `sql_processor.py` to avoid the
name conflict between `sql` module and `pp.sql` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
