cloud-fan commented on a change in pull request #30145:
URL: https://github.com/apache/spark/pull/30145#discussion_r608322336
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -144,12 +147,12 @@ case class GroupingSets(
object GroupingSets {
def apply(
groupingSets: Seq[Seq[Expression]],
- userGivenGroupByExprs: Seq[Expression]): GroupingSets = {
- val groupingSetIndexes =
GroupingSet.computeGroupingSetIndexes(groupingSets)
+ userGivenGroupByExprs: Seq[Expression]): GroupingAnalytic = {
+ val groupingSetIndexes =
GroupingAnalytic.computeGroupingSetIndexes(groupingSets)
GroupingSets(groupingSetIndexes, groupingSets.flatten,
userGivenGroupByExprs)
}
- def apply(groupingSets: Seq[Seq[Expression]]): GroupingSets = {
+ def apply(groupingSets: Seq[Seq[Expression]]): GroupingAnalytic = {
Review comment:
we can probably do the rename in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
