sigmod commented on a change in pull request #32060:
URL: https://github.com/apache/spark/pull/32060#discussion_r608420642
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala
##########
@@ -169,24 +169,33 @@ class OptimizeInSuite extends PlanTest {
}
test("OptimizedIn test: Setting the threshold for turning Set into InSet.") {
- val plan =
- testRelation
- .where(In(UnresolvedAttribute("a"), Seq(Literal(1), Literal(2),
Literal(3))))
- .analyze
-
- withSQLConf(OPTIMIZER_INSET_CONVERSION_THRESHOLD.key -> "10") {
- val notOptimizedPlan = OptimizeIn(plan)
- comparePlans(notOptimizedPlan, plan)
+ {
Review comment:
Yes, it's needed. I added a comment before the test case to explain the
reason. Let me know if it's not clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
