luhenry commented on a change in pull request #30810:
URL: https://github.com/apache/spark/pull/30810#discussion_r609559096
##########
File path: project/SparkBuild.scala
##########
@@ -291,6 +291,12 @@ object SparkBuild extends PomBuild {
publishLocal in SbtCompile := publishTask(publishLocalConfiguration in
SbtCompile).value,
publishLocal := Seq(publishLocal in MavenCompile, publishLocal in
SbtCompile).dependOn.value,
+ javaOptions ++= {
+ val versionParts = System.getProperty("java.version").split("[+.\\-]+",
3)
+ var major = versionParts(0).toInt
+ if (major >= 16) Seq("--add-modules=jdk.incubator.vector") else Seq.empty
Review comment:
Yes, they would have to. It's one of the failsafe to make sure users
don't end up using the feature "by accident". That will be the case until the
Vector API becomes stable (gets out of incubation) and doesn't need this flag
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
