Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/5755#issuecomment-97312152
LGTM - but just to be sure, since the unit tests don't actually cover
loading a jar from the local maven or ivy cache, have you tested it locally? If
you wanted to go above and beyond, you could create unit tests that generate a
maven or ivy dependency in temporary folder and then test that you can load it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
