AngersZhuuuu commented on a change in pull request #30144:
URL: https://github.com/apache/spark/pull/30144#discussion_r609849786
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -32,8 +32,6 @@ trait BaseGroupingSets extends Expression with
CodegenFallback {
def selectedGroupByExprs: Seq[Seq[Expression]]
def groupByExprs: Seq[Expression] = {
- assert(children.forall(_.resolved),
- "Cannot call BaseGroupingSets.groupByExprs before the children
expressions are all resolved.")
Review comment:
> why do we remove this assert? The following code calls
`semanticEquals` and we may get wrong if children are not resolved.
With this check it will failed. Hmm I'm still checking the analysis sequence
of the analyzer to see why this happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
