imback82 commented on a change in pull request #32032:
URL: https://github.com/apache/spark/pull/32032#discussion_r609962724
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -482,7 +482,7 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
case CreateViewStatement(
tbl, userSpecifiedColumns, comment, properties,
- originalText, child, allowExisting, replace, viewType) if child.resolved
=>
Review comment:
We needed this check because `CreateViewCommand.plan` was not a real
child before. Without this check, you could potentially convert
`CreateViewStatement` to `CreateViewCommand` even when
`CreateViewStatement.child` was not resolved yet, and it will remain unresolved
since `CreateViewCommand` didn't have `children`.
Now that `CreateViewCommand.plan` is a real child, I don't think we need the
check any longer since it will be resolved by the analyzer again, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
