Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5473#discussion_r29317973
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingJobProgressListener.scala
---
@@ -17,29 +17,58 @@
package org.apache.spark.streaming.ui
-import scala.collection.mutable.{Queue, HashMap}
+import java.util.LinkedHashMap
+import java.util.{Map => JMap}
+import java.util.Properties
+import scala.collection.mutable.{ArrayBuffer, Queue, HashMap,
SynchronizedBuffer}
+
+import org.apache.spark.scheduler._
import org.apache.spark.streaming.{Time, StreamingContext}
import org.apache.spark.streaming.scheduler._
import
org.apache.spark.streaming.scheduler.StreamingListenerReceiverStarted
import org.apache.spark.streaming.scheduler.StreamingListenerBatchStarted
-import org.apache.spark.streaming.scheduler.BatchInfo
import org.apache.spark.streaming.scheduler.StreamingListenerBatchSubmitted
import org.apache.spark.util.Distribution
private[streaming] class StreamingJobProgressListener(ssc:
StreamingContext)
- extends StreamingListener {
+ extends StreamingListener with SparkListener {
- private val waitingBatchInfos = new HashMap[Time, BatchInfo]
- private val runningBatchInfos = new HashMap[Time, BatchInfo]
- private val completedBatchInfos = new Queue[BatchInfo]
- private val batchInfoLimit =
ssc.conf.getInt("spark.streaming.ui.retainedBatches", 100)
+ private val waitingBatchUIDatas = new HashMap[Time, BatchUIData]
--- End diff --
`Datas` sounds really weird. Just leave it as `BatchUIData`. Or if you want
to follow other hashmaps naming styles `timeToWaitingBatchUIData`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
