cloud-fan commented on a change in pull request #30144:
URL: https://github.com/apache/spark/pull/30144#discussion_r610683447
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -231,3 +235,32 @@ object GroupingID {
if (SQLConf.get.integerGroupingIdEnabled) IntegerType else LongType
}
}
+
+object GroupingAnalytics {
+ def unapply(exprs: Seq[Expression])
+ : Option[(Seq[Seq[Expression]], Seq[Expression])] = {
+ val resolved = exprs.map {
+ case gs: BaseGroupingSets => gs.childrenResolved
+ case other => other.resolved
+ }.forall(_ == true)
+ if (!resolved) {
+ None
+ } else if (!exprs.exists(e =>
e.find(_.isInstanceOf[BaseGroupingSets]).isDefined)) {
Review comment:
do we need to call `find`? I think `BaseGroupingSets` can only appear in
the top level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
