imback82 commented on a change in pull request #32039:
URL: https://github.com/apache/spark/pull/32039#discussion_r610811514
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -138,8 +138,12 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
withProjection :: Nil
- case WriteToDataSourceV2(writer, query) =>
- WriteToDataSourceV2Exec(writer, planLater(query)) :: Nil
+ case WriteToDataSourceV2(relationOpt, writer, query) =>
+ val refreshCacheFunc: () => Unit = () => relationOpt match {
Review comment:
Seems like we are invalidating the cache, and not refreshing?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -847,6 +848,34 @@ class DataSourceV2SQLSuite
}
}
+ test("SPARK-34947: micro batch streaming write should refresh cache") {
Review comment:
"should invalidate cache"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
