Yikun commented on a change in pull request #32122:
URL: https://github.com/apache/spark/pull/32122#discussion_r611134480
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -588,7 +588,7 @@ def withWatermark(self, eventTime, delayThreshold):
Parameters
----------
- eventTime : str or :class:`Column`
+ eventTime : str
Review comment:
The scalar eventTime is also `str`
https://github.com/apache/spark/blob/61d038f26e1beeeb39638fdf9703d2e86d058342/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L753
and python implements is also validated as string
https://github.com/apache/spark/blob/ff1fc5ed4b685b4f5f83d5f600b24f089dd4522e/python/pyspark/sql/dataframe.py#L608-L609
but wrong doc on the param and typehints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
